More public XmlPath members #1013
Conversation
|
Do we need both the constructor and the factory? |
|
/azp run |
Honestly, I think the constructors would be sufficient. I only did that because @ThomasBarnekow suggested it. If you need me to revert the factory, let me know. |
|
Let's just do the constructors |
Fair enough, let me revert the non-constructor related changes |
|
That should do it. |
|
/azp run |
| @@ -21,9 +21,13 @@ namespace DocumentFormat.OpenXml | |||
| public class XmlPath | |||
| { | |||
| /// <summary> | |||
| /// Initializes a new instance of the XmlPath. | |||
| /// Initializes a new instance of the XmlPath from the specified | |||
There was a problem hiding this comment.
can you use <see href=""/> annotations for types here?
There was a problem hiding this comment.
You want me to use <see href=""/> here or <see cref=""/>? If the former, what url should I be using for the classes?
There was a problem hiding this comment.
Cool, just making sure. I'll work on that.
There was a problem hiding this comment.
Should be updated as requested now.
| @@ -54,7 +58,7 @@ internal XmlPath(OpenXmlElement element) | |||
| /// Initializes a new instance of the XmlPath from the specified OpenXmlPart. | |||
|
/azp run |
|
Hi, Since this is approved, do you know when it can be merged into Main? |
|
Done |
This makes the constructors and a couple of static methods in the XmlPath class public.