Skip to content

Fix emitting current connection state on iOS #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2020
Merged

Fix emitting current connection state on iOS #547

merged 1 commit into from
Nov 17, 2020

Conversation

mikolak
Copy link
Collaborator

@mikolak mikolak commented Nov 16, 2020

For reasons unknown casting BOOL: NO to BOOL makes it a YES.

Fixes #540

@dariuszseweryn
Copy link
Collaborator

I guess it may be that (id) is a pointer to a BOOL but when you cast that pointer to BOOL it becomes YES as the pointer is not a nil reference. 🤷‍♂️

@mikolak mikolak force-pushed the fix/#540-connection-state-observation-on-ios branch from 4af8fdf to 011be99 Compare November 17, 2020 14:21
@mikolak mikolak merged commit 33afb00 into develop Nov 17, 2020
@mikolak mikolak deleted the fix/#540-connection-state-observation-on-ios branch November 17, 2020 17:53
mikolak added a commit that referenced this pull request Nov 19, 2020
@mikolak
Release v2.3.1 (#548)
cab2dcc 
* Minor doc fixes (#544)

* Regenerate podfile for example (#545)

* Fix connection timeout on iOS (#546)

Fixes #478

* Fix emitting current connection state on iOS (#547)

Fixes #540

* Release 2.3.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariuszseweryn dariuszseweryn dariuszseweryn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

observeConnectionState(emitCurrentValue: true) emits connected state for disconnected device
2 participants
@mikolak @dariuszseweryn