fix(k8s-views-namespaces): use custom all value for created_by filter #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All other filters use a custom all value as it's much more efficient than constructing a query with every single created_by value. It also prevents queries from becoming too long and rejected by Prometheus. Fixes: dotdc#146
dotdc
approved these changes
Apr 10, 2025
|
Thank you for the fix @uhthomas ! |
|
🎉 This PR is included in version 2.7.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Required Fields
🔎 What kind of change is it?
fix
🎯 What has been changed and why do we need it?
All other filters use a custom all value as it's much more efficient than constructing a query with every single created_by value. It also prevents queries from becoming too long and rejected by Prometheus.
Optional Fields
✔️ Which issue(s) this PR fixes?
#146
💬 Additional information?