feat(k8s-views-nodes): Support FQDN nodename #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is fairly common for the server hostname to be a FQDN (e.g. `node-01.example.com`), while the node is known to Kubernetes by it's short name (e.g. `node-01`). By relaxing the regex that matches the `nodename` label to determine the `instance` name, we can cover that case without the need to relabel metrics. Signed-off-by: Benoît Knecht <[email protected]>
|
🎉 This PR is included in version 2.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
dotdc
added a commit
that referenced
this pull request
Apr 10, 2025
Co-authored-by: David Calvert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Required Fields
🔎 What kind of change is it?
🎯 What has been changed and why do we need it?
It is fairly common for the server hostname to be a FQDN (e.g.
node-01.example.com), while the node is known to Kubernetes by it's short name (e.g.node-01).By relaxing the regex that matches the
nodenamelabel to determine theinstancename, we can cover that case without the need to relabel metrics.