Sets expiry of token generated using refresh_token to that of original token [Fixes #1364] #1366
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #1364 .
See the following example:
Doorkeeper Configuration
Behavior without this fix:
When refreshing a token(originally created using authorization_code flow having the expiry of 2 hours), the new token will have an expiry of 3 hours.
When refreshing a token(originally created using password flow having the expiry of 1 hour), the new token will have an expiry of 3 hours.
Behavior after this fix:
When refreshing a token(originally created using authorization_code flow having the expiry of 2 hours), the new token will also have an expiry of 2 hours.
When refreshing a token(originally created using password flow having the expiry of 1 hour), the new token will also have an expiry of 1 hour.