Skip to content

feat: Added NumberedItemReference #3042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 16, 2025
Merged

feat: Added NumberedItemReference #3042

merged 5 commits into from
Apr 16, 2025

Conversation

dolanmiu
Copy link
Owner

@dolanmiu dolanmiu commented Apr 16, 2025

Resolves: #3041

Adding linting and more tests to make it pass CI

Thank you!

@dolanmiu dolanmiu changed the title Numbered items feat: Added NumberedItemReference Apr 16, 2025
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5af1045) to head (d1856d0).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #3042   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          289       290    +1     
  Lines         8712      8737   +25     
  Branches      1412      1415    +3     
=========================================
+ Hits          8712      8737   +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dolanmiu dolanmiu merged commit 7f26bad into master Apr 16, 2025
10 checks passed
@dolanmiu dolanmiu deleted the numbered-items branch April 16, 2025 07:54
@Alexnortung
Copy link
Contributor

Hi @dolanmiu,

Thanks for merging my commit! And thanks for the great work. I noticed that the lint was failing, saying

Use a type instead of an interface

However the documentation says (link)

Do not use type, but rather use Interfaces. type cannot be extended, and a class cannot implement it.

Maybe this should be changed? :)

@dolanmiu
Copy link
Owner Author

Documentation updated. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants