Skip to content

Add Packer.pack and Packer.toArrayBuffer #2959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2025

Conversation

joshkel
Copy link
Contributor

@joshkel joshkel commented Feb 15, 2025

To mirror patchDocument's outputType parameter.

See #2920

Quoting from that discussion:

Suggestion:

  • Add a Packer.pack or Packer.to method that takes an outputType parameter.
  • Change the existing Packer.to... methods to use this new method.
  • Optionally, add a Packer.toArrayBuffer method for consistency with the existing Packer.to... methods.

I think I may have explained my suggestion poorly - I was suggesting doing all of the above. This PR is an implementation of that. @dolanmiu, if you'd rather that I just add a toArrayBuffer function instead, I'm happy to go that route - just let me know. Thanks!

Specific notes:

joshkel and others added 2 commits February 15, 2025 17:17
To mirror patchDocument's outputType parameter.

See dolanmiu#2920
Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (05fcf6e) to head (9887d7a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2959   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          286       287    +1     
  Lines         8390      8387    -3     
  Branches      1410      1410           
=========================================
- Hits          8390      8387    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolanmiu dolanmiu merged commit 170309a into dolanmiu:master Feb 16, 2025
8 checks passed
@joshkel joshkel deleted the packer-output-type branch February 17, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants