fix: patchDocument, looks for namspaces more carefully over whole doc… #2943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test to your PR? |
|
sorry guys, i don't think that i have enough time to write tests... and by specific of my work - i have to fix few bugs in your library to satisfy our requirements... |
|
Hi @13W Sure, yes, can you explain each fix? Maybe it can be a comment in the code |
added 4 commits
April 16, 2025 08:59
…ument
added support of different placeholder brackets, default `{{`: `}}`
extended inputDataType to accept JSZip
added parameter `recursive`(= true by default) to be able to disable this behavior
|
Almost ready, just need to write tests Tests are written |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2943 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 290 290
Lines 8781 8796 +15
Branches 1420 1423 +3
=========================================
+ Hits 8781 8796 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ument
added support of different placeholder brackets, default
{{:}}extended inputDataType to accept JSZip