Skip to content

Add compression for dist mode; README updates. #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

mwistrand
Copy link
Contributor

Resolves #11. Adds the compression-webpack-plugin and brotli-webpack-plugin plugins for compressing production builds with gzip and brotli, respectively. Also includes README documentation for each current "build-app" key in the .dojorc.

@codecov
Copy link

codecov bot commented Jan 5, 2018

Codecov Report

Merging #24 into master will decrease coverage by 0.63%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   59.71%   59.08%   -0.64%     
==========================================
  Files           8        8              
  Lines         427      435       +8     
  Branches       92       93       +1     
==========================================
+ Hits          255      257       +2     
- Misses        172      178       +6
Impacted Files Coverage Δ
src/dist.config.ts 34.54% <33.33%> (-1.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcfa228...906b527. Read the comment docs.

@mwistrand mwistrand requested a review from matt-gadd January 5, 2018 22:53
Copy link
Contributor

@matt-gadd matt-gadd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we can make the compression mode an or. brotli is not supported by all servers or browsers, so it should be complementary to gzip?

I'm also not sure about delegating the options off to the webpack plugins themselves as it seems to go against the minimal configuration, and the abstraction above webpack that the build command is designed to provide.

@mwistrand
Copy link
Contributor Author

That's a fair point. I can update the rc to accept an array of option objects so that both can be generated side-by-side.

@mwistrand mwistrand force-pushed the 11-dist-compression branch from d1565ac to 7cee2d7 Compare January 12, 2018 14:31
@mwistrand
Copy link
Contributor Author

@matt-gadd This is ready for another review now that conflicts with master have been resolved.

@mwistrand mwistrand force-pushed the 11-dist-compression branch from 7cee2d7 to 4629083 Compare August 13, 2018 17:10
@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Matt Wistrand seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

Add compression-webpack-plugin and brotli-webpack-plugin for compressing
production builds with gzip and brotli, respectively.
@mwistrand mwistrand force-pushed the 11-dist-compression branch from 4629083 to 906b527 Compare August 13, 2018 17:37
@mwistrand mwistrand merged commit 481f87c into dojo:master Aug 14, 2018
@mwistrand mwistrand deleted the 11-dist-compression branch August 7, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants