Skip to content

Support entities with association column names that conflict with a field name #11857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 3.3.x
Choose a base branch
from

Conversation

kalifg
Copy link
Contributor

@kalifg kalifg commented Mar 5, 2025

If an entity is defined such that it has a field $a based on a column c, and an association field $b based on a column a, hydration will fail. This is because the data array that is created during hydration uses field names for keys except for associations. For associations it uses the column names, leading to a conflict.

This PR adds a prefix to the column-valued array keys to avoid clashes. The prefix uses characters that could not occur in a field name so it should be safe for all possible field and column names.

Copy link
Contributor

github-actions bot commented Jun 3, 2025

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.

@github-actions github-actions bot added the Stale label Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant