Final tests and adjustments to allow mapping properties with hooks #11852
+243
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
symfony/var-exporter added support for hooked properties symfony/symfony#59965 |
Also prevent using property hooks with symfony/var-exporter for now. They did add support in a recent version, but my tests still failed with that, so not bothering with that for now.
beberlei
commented
Mar 29, 2025
| return; | ||
| } | ||
|
|
||
| foreach ($class->propertyAccessors as $propertyAccessor) { |
There was a problem hiding this comment.
ClassMetadataFactory:: validateRuntimeMetadata is called to early, as it does not have access to any accessors yet. However this is in persistence and cannot be changed easily.
Here its available, however at the downside of being called in every request even when loaded from cache.
beberlei
changed the title
greg0ire
previously approved these changes
Apr 5, 2025
SenseException
previously approved these changes
Apr 7, 2025
greg0ire
reviewed
Apr 9, 2025
greg0ire
approved these changes
Apr 12, 2025
|
Thanks @beberlei ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for non-virtual property hooks now that native lazy objects are supported.
Property hooks are not supported when using symfony/var-exporter.