UnitOfWork::executeUpdates foreach duplicates bug under recursion

[garex]

Bug Report

Q	A
Version	2.16.0 till present

Summary

Doctrine ORM v2.16.0 internally starts to execute all updates by single foreach on single UoW property.

Events firing stays inside foreach.

In every iteration property entityUpdates is unsetted. But if we will have recursive call, that will return us to executeUpdates -- then unsetted in later recursive call update will be exceuted on 1st level call.

Current behavior

Duplicated iteration calls and event firing.

Expected behavior

Iteration that respects unsetted entityUpdates from inner recursion level.

How to reproduce

All details, examples and demos are at https://github.com/garex/doctrine-orm-updates-bug

See github actions and unit tests.

Fix also simple:

                foreach ($it = new \ArrayIterator($this->entityUpdates) as $oid => $entity) {
                    // ...
                    unset($it[$oid]); // Unset here also needed
                    unset($this->entities[$oid]);
                    // ...
                }
            }

[garex]

@greg0ire @stof @nicolas-grekas @xabbuh can you please suggest who and when can triage this bug?

It looks like serious from 1st view.

[nicolas-grekas]

I know very little about the topic but since Doctrine is open-source, you might want to give this a try and send a PR?

[garex]

I know very little about the topic but since Doctrine is open-source, you might want to give this a try and send a PR?

I can, but could some of authors decide if it's really needed? And which of two options to use: ArrayIterator or just move events firing out of foreach?

[garex]

I know very little about the topic but since Doctrine is open-source, you might want to give this a try and send a PR?

Btw, as an author of parsing lib you should better than average developer know how foreach internally works )

[garex]

I know very little about the topic but since Doctrine is open-source, you might want to give this a try and send a PR?

Btw, as an author of parsing lib you should better than average developer know how foreach internally works )

My bad, I thought you are @nikic )) Anyway.

[garex]

@mpdude may be you can look into and suggest is it really bug and if it is -- how to better fix it -- by upgrading foreach or by moving events firing out of foreach?