Include object name in editor exception messages #6943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
May 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the object name in the messages of the exceptions thrown by the corresponding editor (suggested in #6934 (comment)).
The pattern is the following:
Table,Index), accept the object name in all static constructors of theInvalid{Object}Definitionexception except fornameNotSet(). The logic is that if the name is not set,nameNotSet()would be thrown, so if a different exception is being constructed, the name is set.UniqueConstraint,ForeignKeyConstraint), accept the nullable object name in all static constructors except fornameNotSet(). If the name is not set, display<unnamed>instead of the name.