Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPUnit 12.1.0 #6888

Draft
wants to merge 1 commit into
base: 4.2.x
Choose a base branch
from
Draft

PHPUnit 12.1.0 #6888

wants to merge 1 commit into from

Conversation

morozov
Copy link
Member

@morozov morozov commented Apr 4, 2025

Change summary

  1. Use the NativeType enum as an argument for IsType instead of IsType constants.
  2. Use the DataProvider annotation instead of @dataProvider.
  3. Use ini_set and ini_restore instead of TestCase#iniSet().
  4. Annotate test method parameters passed as an argument to InvocationStubberImplementation#method() as non-empty-string to keep PHPStan happy.

Known issues

PhpStorm as of version 2024.3.5 doesn't support PHPUnit 11 or newer (see WI-75593). As a workaround, one may copy phpunit.xml.dist as phpunit.xml and configure cacheResultFile (see WI-50445).

@morozov morozov added this to the 4.2.4 milestone Apr 4, 2025
@morozov
Copy link
Member Author

morozov commented Apr 4, 2025

It looks like PHPUnit 11 requires PHP 8.2, PHPUnit 12 requires PHP 8.3 – both constraints are justified given the upstream support for these PHP versions.

Should we require PHP 8.3 starting DBAL 4.3.0 (#6889)?

@morozov morozov mentioned this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant