Fix merging driver options in the pdo_sqlsrv driver test

[morozov]

This issue affects only the test suite and only if the pdo_sqlsrv connection is configured with additional DSN parameters, for instance:

<var name="db_driver_option_TrustServerCertificate" value="1" />

In this case, the testDriverOptions() test will fail with the following error:

phpunit -c phpunit-pdo-sqlsrv.xml \
  --filter testDriverOptions \
  tests/Functional/Driver/PDO/SQLSrv/DriverTest.php

There was 1 error:

1) Doctrine\DBAL\Tests\Functional\Driver\PDO\SQLSrv\DriverTest::testDriverOptions
Doctrine\DBAL\Driver\PDO\Exception: SQLSTATE[IMSSP]: An unsupported attribute was designated on the PDO object.

src/Driver/PDO/Exception.php:24
src/Driver/PDO/SQLSrv/Driver.php:65
tests/Functional/Driver/PDO/SQLSrv/DriverTest.php:50
tests/Functional/Driver/PDO/SQLSrv/DriverTest.php:68

The reason is that the pdo_sqlsrv DBAL driver accepts both the DSN and PDO parameters in the driverOptions connection parameter:

dbal/src/Driver/PDO/SQLSrv/Driver.php

Lines 36 to 40 in 54be50e

	if (is_int($option)) {
	$driverOptions[$option] = $value;
	} else {
	$dsnOptions[$option] = $value;
	}

Prior to the fix, the code would merge the configuration provided by PHPUnit with the configuration provided by the test using array_merge() and lose the key representing the PDO attribute:

$dsnOptions = ['TrustServerCertificate' => '1'];
$pdoOptions = [8 => 1];

var_dump(array_merge($dsnOptions, $pdoOptions));

// array(2) {
//   ["TrustServerCertificate"]=>
//   string(1) "1"
//   [0]=>
//   int(1)
// }

array_replace() preserves numeric keys in the case if both string string keys designated for the DSN and numeric keys designated for PDO are present.

[greg0ire]

Nice catch!