Introduce PrimaryKeyConstraint #6867
Merged
+539
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the primary key constraint is represented in DBAL as an index with the "primary" flag. This leads to various sorts of issues, for example:
Table#renameIndex()
likely doesn't work for primary key constraints.This PR deprecates indexes with the "primary" flag in favor of
PrimaryKeyConstraint
.Technical details
setPrimaryKey()
method is being deprecated in favor ofTable::addPrimaryKeyConstraint()
. The "add" verb better corresponds to the SQL syntax (ALTER TABLE <name> ADD CONSTRAINT
). The currently existing "set" method already has the "add" semantics (a PK cannot be set twice).dropPrimaryKey()
is not being deprecated. Even though there's now a slight inconsistency in naming, eventuallyTable
will become immutable, so it will be deprecated. This way, I'm reducing the number of deprecations.PrimaryKeyConstraint#equals()
will be added in 5.0.x, not here, since it's not necessary for the upgrade and isn't always possible to use.