Skip to content

Add an integration test for replacing a foreign key constraint #6825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

morozov
Copy link
Member

@morozov morozov commented Mar 7, 2025

Constraints cannot be modified neither in the DBAL Schema API, nor in databases – they can be dropped and added. However, Comparator and TableDiff represent non-equal foreign key constraints with the same name as "modified".

I want to deprecate the notion of "modified foreign keys", but before that I need to make sure that handling one constraint being replaced by another is covered by an integration test.

@morozov morozov added this to the 4.2.3 milestone Mar 7, 2025
@morozov morozov marked this pull request as ready for review March 7, 2025 06:30
@morozov morozov requested a review from greg0ire March 7, 2025 06:33
@morozov morozov merged commit 33d2d7f into doctrine:4.2.x Mar 7, 2025
66 checks passed
@morozov morozov deleted the fk-replace-test branch March 7, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants