Fix creation of unnamed unique constraints #6668
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that even though the
$name
parameter in theUniqueConstraint
constructor isn't nullable, the original implementation attempted to handle constraints with empty name:dbal/lib/Doctrine/DBAL/Platforms/AbstractPlatform.php
Lines 2396 to 2397 in b0cc669
Also, constraint names in SQL are optional for all supported platforms. Therefore, I consider the behavior of improper handling of unnamed constraints a bug.
Two issues are being fixed:
CREATE TABLE
andALTER TABLE
).Both of these edge cases are correctly handled for foreign key constraints, which can be referenced as the proper implementation.