Merge 3.9.x up into 4.2.x #6555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_I managed to break this behaviour in other PR so this should be covered._ It tests basic walkthrough where we nest transactions, propagate the result through the transaction stack and also that it is committed and not rolled back.
test: cover nested transactions
|
@simPod I tried merging up your commit, but it does not seem to work on 4.2.x, for Oracle. Did I do something wrong when resolving conflicts, or is it because of changes specific to this branch? |
|
Just to be sure, you mean IBM, right? 
|
|
Oh yeah sorry. |
|
This is tmp fix simPod/dbal@ TLDR transaction nesting is not working on DB2 now because of this Line 1085 in 220aec4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.