Remove AbstractMySQLPlatform::getColumnTypeSQLSnippets()

UPGRADE.md

@@ -8,6 +8,11 @@ awareness about deprecated code.
 
 # Upgrade to 4.0
 
+## BC BREAK: removed `AbstractMySQLPlatform` methods.
+
+1. `getColumnTypeSQLSnippets()`,
+2. `getDatabaseNameSQL()`.
+
 ## BC BREAK: Removed lock-related `AbstractPlatform` methods
 
 The methods `AbstractPlatform::getReadLockSQL()`, `::getWriteLockSQL()` and `::getForUpdateSQL()` have been removed

src/Platforms/AbstractMySQLPlatform.php

@@ -18,13 +18,11 @@
 use Doctrine\DBAL\SQL\Builder\SelectSQLBuilder;
 use Doctrine\DBAL\TransactionIsolationLevel;
 use Doctrine\DBAL\Types\Types;
-use Doctrine\Deprecations\Deprecation;
 
 use function array_merge;
 use function array_unique;
 use function array_values;
 use function count;
-use function func_get_args;
 use function implode;
 use function in_array;
 use function is_numeric;
@@ -219,27 +217,6 @@ public function supportsColumnCollation(): bool
         return true;
     }
 
-    /**
-     * @deprecated Use {@see getColumnTypeSQLSnippet()} instead.
-     *
-     * The SQL snippets required to elucidate a column type
-     *
-     * Returns an array of the form [column type SELECT snippet, additional JOIN statement snippet]
-     *
-     * @return array{string, string}
-     */
-    public function getColumnTypeSQLSnippets(string $tableAlias = 'c'): array
-    {
-        Deprecation::triggerIfCalledFromOutside(
-            'doctrine/dbal',
-            'https://github.com/doctrine/dbal/pull/6202',
-            'AbstractMySQLPlatform::getColumnTypeSQLSnippets() is deprecated. '
-            . 'Use AbstractMySQLPlatform::getColumnTypeSQLSnippet() instead.',
-        );
-
-        return [$this->getColumnTypeSQLSnippet(...func_get_args()), ''];
-    }
-
     /**
      * The SQL snippet required to elucidate a column type
      *

src/Schema/MySQLSchemaManager.php

@@ -343,8 +343,7 @@ protected function selectTableNames(string $databaseName): Result
 
     protected function selectTableColumns(string $databaseName, ?string $tableName = null): Result
     {
-        // @todo 4.0 - call getColumnTypeSQLSnippet() instead
-        [$columnTypeSQL, $joinCheckConstraintSQL] = $this->platform->getColumnTypeSQLSnippets('c', $databaseName);
+        $columnTypeSQL = $this->platform->getColumnTypeSQLSnippet('c', $databaseName);
 
         $sql = 'SELECT';
 
@@ -365,7 +364,6 @@ protected function selectTableColumns(string $databaseName, ?string $tableName =
 FROM information_schema.COLUMNS c
     INNER JOIN information_schema.TABLES t
         ON t.TABLE_NAME = c.TABLE_NAME
-    $joinCheckConstraintSQL
 SQL;
 
         // The schema name is passed multiple times as a literal in the WHERE clause instead of using a JOIN condition

tests/Functional/Schema/MySQLSchemaManagerTest.php

@@ -394,6 +394,11 @@ public function testJsonColumnType(): void
         $table->addColumn('col_json', Types::JSON);
         $this->dropAndCreateTable($table);
 
+        // Remove the comment from the column to ensure the type is detected correctly from the check constraints.
+        if ($this->connection->getDatabasePlatform() instanceof MariaDBPlatform) {
+            $this->connection->executeStatement('ALTER TABLE test_mysql_json CHANGE COLUMN col_json col_json JSON');
+        }
+
         $columns = $this->schemaManager->listTableColumns('test_mysql_json');
 
         self::assertInstanceOf(JsonType::class, $columns['col_json']->getType());