Deprecate AbstractMySQLPlatform::getColumnTypeSQLSnippets() #6213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olumn-type-sql-snippets
ausi
changed the title
|
Deprecations have to be documented in UPGRADE.md. |
ausi
changed the title
derrabus
reviewed
Nov 5, 2023
ausi
force-pushed
the
feature/deprecate-column-type-sql-snippets
branch
from
b176bfc to
ea9d435
Compare
This was referenced Nov 5, 2023
…snippets # Conflicts: # src/Platforms/AbstractMySQLPlatform.php
derrabus
previously approved these changes
Nov 5, 2023
Co-authored-by: Alexander M. Turek <[email protected]>
derrabus
approved these changes
Nov 5, 2023
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Nov 5, 2023
* 3.8.x: Deprecate AbstractMySQLPlatform::getColumnTypeSQLSnippets() (doctrine#6213) Fix MariaDB list columns performance (doctrine#6202)
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Nov 11, 2023
* 3.8.x: Enable skipping locked rows in QueryBuilder Fix coding standard violation Remove unused unit test fixtures Add Oracle v23 to CI testing (doctrine#6217) Extend `AbstractMySQLPlatform::getColumnTypeSQLSnippets()` deprecation layer (doctrine#6215) Deprecate AbstractMySQLPlatform::getColumnTypeSQLSnippets() (doctrine#6213) Fix MariaDB list columns performance (doctrine#6202)
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Nov 11, 2023
* 3.8.x: Enable skipping locked rows in QueryBuilder Fix coding standard violation Remove unused unit test fixtures Add Oracle v23 to CI testing (doctrine#6217) Extend `AbstractMySQLPlatform::getColumnTypeSQLSnippets()` deprecation layer (doctrine#6215) Deprecate AbstractMySQLPlatform::getColumnTypeSQLSnippets() (doctrine#6213) Fix MariaDB list columns performance (doctrine#6202)
derrabus
pushed a commit
that referenced
this pull request
Nov 13, 2023
| Q | A |------------- | ----------- | Type | feature | Fixed issues | #6202 (comment) #### Summary Removes `AbstractMySQLPlatform::getColumnTypeSQLSnippets()` Needs to be rebased after #6202 and #6213 got merged upstream.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deprecates
AbstractMySQLPlatform::getColumnTypeSQLSnippets()Needs to be rebased after #6202 got merged upstream.Done.