[Oracle] Fix handling timestamp with time zone #6012
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansys
changed the title
phansys
force-pushed
the
oracle_tz
branch
4 times, most recently
from
e0b4cbc to
1a7930c
Compare
derrabus
requested changes
May 8, 2023
| @@ -28,7 +28,7 @@ public function connect( | |||
| . " NLS_TIME_FORMAT = 'HH24:MI:SS'" | |||
| . " NLS_DATE_FORMAT = 'YYYY-MM-DD HH24:MI:SS'" | |||
| . " NLS_TIMESTAMP_FORMAT = 'YYYY-MM-DD HH24:MI:SS'" | |||
| . " NLS_TIMESTAMP_TZ_FORMAT = 'YYYY-MM-DD HH24:MI:SS TZH:TZM'" | |||
| . " NLS_TIMESTAMP_TZ_FORMAT = 'YYYY-MM-DD HH24:MI:SSTZH:TZM'" | |||
There was a problem hiding this comment.
This change certainly makes sense, but I fear that we break existing applications that rely on the current behavior.
Let's add a new constructor parameter to opt in to the correct format and trigger a deprecation if the app does not opt in. And that also means that we need to target 3.7.x because we don't introduce deprecations in a bugfix release.
phansys
force-pushed
the
oracle_tz
branch
3 times, most recently
from
6a4e988 to
45ba3d5
Compare
|
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
|
This pull request was closed due to inactivity. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
InitializeSession::connect(), as it was not compatible with what is declared atOraclePlatform::getDateTimeTzFormatString();OraclePlatform::getNowExpression().This bug was detected after adding the functional test for the timezone aware fields in #6006.