Merge 3.6.x into 4.0.x #5891
Merged
Merge 3.6.x into 4.0.x #5891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to allow apps to override the default schema managers
Use psalm-assert to get rid of `assert()` calls
… to PDO methods Co-authored-by: kang <[email protected]>
Make sure only PDO parameter types are passed to PDO methods
* 3.5.x: Make sure only PDO parameter types are passed
Add the PgSQL driver
…-factory Introduce the `SchemaManagerFactory` interface
Co-authored-by: Max <[email protected]>
…r-handling Raise exception if `pg_send_*()` calls fail
derrabus
force-pushed
the
4.0.x
branch
3 times, most recently
from
15bce14 to
1124ca5
Compare
derrabus
commented
Feb 1, 2023
src/Driver/PgSQL/Connection.php
Outdated
Comment on lines
46
to
53
| public function __destruct() | ||
| { | ||
| if (isset($this->connection)) { | ||
| @pg_close($this->connection); | ||
| } | ||
|
|
||
| unset($this->connection); | ||
| } |
There was a problem hiding this comment.
I had to insert this destructor to avoid a deadlock in our functional test suite. Backported as #5892.
There was a problem hiding this comment.
Let's wait for the necessity of unset($this->connection);
* 3.6.x: Optimize pgsql queries without parameters Raise exception if pg_send_*() calls fail Add the PgSQL driver Make sure only PDO parameter types are passed [Docs] Add IBM DB2 to `configuration.rst` Use psalm-assert to get rid of assert() calls Introduce the SchemaManagerFactory interface
greg0ire
approved these changes
Feb 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.