Skip to content

PgSQL driver improvement #5887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

PgSQL driver improvement #5887

wants to merge 1 commit into from

Conversation

maxm86545
Copy link
Contributor

@maxm86545 maxm86545 commented Jan 31, 2023 •
edited
Loading

Q A
Type improvement

Summary

  • Exception if $result === false.
  • No prepare statement for query() and exec().
  • Possible false result for beginTransaction, commit and rollBack.

derrabus
derrabus requested changes Jan 31, 2023
View reviewed changes
derrabus
derrabus reviewed Jan 31, 2023
View reviewed changes
@derrabus
Copy link
Member

The tests are still red. 😕

@derrabus derrabus mentioned this pull request Jan 31, 2023
Merged
@derrabus
Copy link
Member

Here is my attempt at the exec()/query() optimization: #5889.

@maxm86545 maxm86545 closed this Feb 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@derrabus derrabus derrabus requested changes

Assignees
No one assigned
Labels
Connections Failing Test Improvement pgsql PostgreSQL Prepared Statements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxm86545 @derrabus