Use default schema if $tableName
has no namespace.
#5765
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When 2 same name tables exist in difference schema, eg:
public.table
andanother.table
,$this->schemaManager->listTableColumns('table')
will list and mix columns from both tables.I have confirmed
listTableColumns
is working correctly before #5586.This PR fixes the column issue while respecting #5586
listTables
fix.Steps to reproduce
Run
$this->schemaManager->listTableColumns('table')
Actual
List
table
columns mixed frompublic
andanother
schema.Expected
List
table
columns from thepublic
schema only.