Mark SchemaDiff public properties internal #5758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch continues the API refactoring previously done in #5657 and #5717.
Additionally, it deprecates the functionality of tracking orphaned foreign keys in the schema diff. This functionality was introduced in bf0ef0d without any tests or description of the problem that it was meant to solve. It implements dropping foreign keys referencing the table when the table is dropped. There's no reason why it should be done automatically. Besides enforcing data integrity at the row level, a foreign key enforces it at the table level. If this enforcement is no longer necessary, the constraint should be dropped explicitly.