Fixed various typos #5716
Fixed various typos #5716
Conversation
|
@greg0ire Not sure if you get notified on new pushes, so just added the backwards-compatible function |
|
I do get notified. |
|
You can run |
|
Thanks for all your help! |
|
I've done it for you, and also, I fixed up the backwards-compat layer commit into the right commit. 👍 |
|
Oh wow, thank you so much! |
| @@ -186,11 +186,19 @@ public function spansColumns(array $columnNames) | |||
| } | |||
|
|
|||
| /** | |||
| * Checks if the other index already fulfills all the indexing and constraint needs of the current one. | |||
| * Keeping misspelled function name for backwards compatibility | |||
There was a problem hiding this comment.
Although we need to keep the method around in the current major release, it should be deprecated and removed in the next major.
There was a problem hiding this comment.
Yep, @greg0ire already mentioned that.
There was a problem hiding this comment.
@morozov I think this can be merged as is, then the deprecation can be added on 3.5.x
There was a problem hiding this comment.
@nexxai please don't mark as resolved conversations you do not open in general, and here in particular because it hides my comment.
There was a problem hiding this comment.
Oh no, I'm sorry! I'll leave them open for the commenter to close. Again, my apologies.
There was a problem hiding this comment.
#5716 (comment) doesn't seem to be addressed. The method needs to be annotated as deprecated, and a note in UPGRADE.md added.
|
@morozov have you seen my comment on this? |
|
No, I missed that one. |
|
Confirmed: I've subscribed to #5720 and will send the appropriate PR to 3.5.x when it's been merged. Thanks for both of your help and understanding through this process. |
Summary
Cleaning up typos throughout the codebase