Skip to content

Remove conditional comments for MySQL older than 5.1.16 #5675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2022

Conversation

morozov
Copy link
Member

@morozov morozov commented Sep 18, 2022

The support for MySQL 5.6 and older was dropped in #5089. The removal of the conditional comments allows to remove the workaround for the internal SQL parser in PDO.

@morozov morozov added this to the 4.0.0 milestone Sep 18, 2022
@morozov morozov marked this pull request as ready for review September 18, 2022 17:14
@morozov morozov requested a review from greg0ire September 18, 2022 17:15
@morozov morozov merged commit 774af88 into doctrine:4.0.x Sep 18, 2022
@morozov morozov deleted the remove-mysql-5.0-leftovers branch September 18, 2022 18:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants