Skip to content

Optimize MySQLSchemaManager::selectTableColumns() #5639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2022
Merged

Optimize MySQLSchemaManager::selectTableColumns() #5639

merged 1 commit into from
Sep 1, 2022

Conversation

m-vo
Copy link
Contributor

@m-vo m-vo commented Aug 31, 2022

Q A
Type regression
Fixed issues #5638

This PR replaces the join's first ON condition with a literal in the WHERE clause. I also stole the comment from #5202 as it applies here as well.

@m-vo m-vo mentioned this pull request Aug 31, 2022
Closed
@morozov morozov linked an issue Aug 31, 2022 that may be closed by this pull request
Performance degradation in MySQLSchemaManager #5638
Closed
@morozov morozov added this to the 3.4.4 milestone Aug 31, 2022
@morozov morozov merged commit 488f9d2 into doctrine:3.4.x Sep 1, 2022
@morozov
Copy link
Member

morozov commented Sep 1, 2022

Thanks, @m-vo!

@morozov morozov added the Bug label Sep 1, 2022
@morozov morozov mentioned this pull request Sep 6, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@morozov morozov morozov approved these changes

Assignees
No one assigned
Labels
Bug MySQL Performance Regression
Projects
None yet
Milestone
3.4.4
Development

Successfully merging this pull request may close these issues.

Performance degradation in MySQLSchemaManager
2 participants
@m-vo @morozov