Skip to content

Deprecate array and object column types #5470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2022
Merged

Deprecate array and object column types #5470

merged 1 commit into from
Jun 28, 2022

Conversation

morozov
Copy link
Member

@morozov morozov commented Jun 28, 2022 •
edited
Loading

The array and object column types use PHP built-in serialization. Without additional configuration (specifically, the allowed_classes option), which the API of these types doesn't allow, the usage of built-in serialization may lead to security issues (see object injection).

@morozov morozov added this to the 3.4.0 milestone Jun 28, 2022
@morozov morozov requested review from greg0ire and derrabus June 28, 2022 14:33
@morozov morozov marked this pull request as ready for review June 28, 2022 14:33
derrabus
derrabus approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@morozov morozov merged commit 541e9dd into doctrine:3.4.x Jun 28, 2022
@morozov morozov mentioned this pull request Jun 28, 2022
Closed
@morozov morozov deleted the deprecate-array-object branch June 28, 2022 15:12
@morozov morozov mentioned this pull request Jul 3, 2022
Merged
@greg0ire greg0ire mentioned this pull request Jul 10, 2022
Merged
@phansys phansys mentioned this pull request Apr 12, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@derrabus derrabus derrabus approved these changes

@greg0ire greg0ire Awaiting requested review from greg0ire

Assignees
No one assigned
Labels
Deprecation Types
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@morozov @derrabus