Deprecate Driver::getSchemaManager() in favor of AbstractPlatform::createSchemaManager() #5458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operation of creating a schema manager doesn't belong to the driver layer: the driver represents transport. Different transports use the same schema management logic for the same platform. The very fact that
Driver::getSchemaManager()
is implemented only in abstract driver classes illustrates that.At the same time, the schema management logic may depend on the platform vendor and the platform version:
dbal/src/Schema/MySQLSchemaManager.php
Lines 244 to 248 in d4d9389
But currently, it's challenging to have different schema managers for different platform vendors or versions.