Skip to content

Forward compatibility with PHPUnit 9.3 #4079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public static function executeDataProvider(): iterable
public function testConvertNonTerminatedLiteral(string $sql, string $message): void
{
$this->expectException(OCI8Exception::class);
$this->expectExceptionMessageRegExp($message);
$this->expectExceptionMessageMatches($message);
OCI8Statement::convertPositionalToNamedPlaceholders($sql);
}

Expand Down
37 changes: 10 additions & 27 deletions tests/Doctrine/Tests/DBAL/Schema/SchemaTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -378,27 +378,19 @@ public function testVisitsVisitor(): void
->method('acceptSchema')
->with($schema);

$visitor->expects($this->at(1))
$visitor->expects(self::exactly(2))
->method('acceptTable')
->with($schema->getTable('baz'));
->withConsecutive(
[$schema->getTable('baz')],
[$schema->getTable('bla.bloo')]
);

$visitor->expects($this->at(2))
->method('acceptTable')
->with($schema->getTable('bla.bloo'));

$visitor->expects($this->exactly(2))
->method('acceptTable');

$visitor->expects($this->at(3))
$visitor->expects(self::exactly(2))
->method('acceptSequence')
->with($schema->getSequence('moo'));

$visitor->expects($this->at(4))
->method('acceptSequence')
->with($schema->getSequence('war'));

$visitor->expects($this->exactly(2))
->method('acceptSequence');
->withConsecutive(
[$schema->getSequence('moo')],
[$schema->getSequence('war')]
);

self::assertNull($schema->visit($visitor));
}
Expand Down Expand Up @@ -436,9 +428,6 @@ public function testVisitsNamespaceVisitor(): void
->method('acceptNamespace')
->with('bla');

$visitor->expects($this->exactly(3))
->method('acceptNamespace');

$visitor->expects($this->at(4))
->method('acceptTable')
->with($schema->getTable('baz'));
Expand All @@ -447,9 +436,6 @@ public function testVisitsNamespaceVisitor(): void
->method('acceptTable')
->with($schema->getTable('bla.bloo'));

$visitor->expects($this->exactly(2))
->method('acceptTable');

$visitor->expects($this->at(6))
->method('acceptSequence')
->with($schema->getSequence('moo'));
Expand All @@ -458,9 +444,6 @@ public function testVisitsNamespaceVisitor(): void
->method('acceptSequence')
->with($schema->getSequence('war'));

$visitor->expects($this->exactly(2))
->method('acceptSequence');

self::assertNull($schema->visit($visitor));
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,12 @@ public function testGetQueriesUsesAcceptedForeignKeys(): void

$collector = new DropSchemaSqlCollector($platform);

$platform->expects($this->exactly(2))
->method('getDropForeignKeySQL');

$platform->expects($this->at(0))
->method('getDropForeignKeySQL')
->with($keyConstraintOne, $tableOne);

$platform->expects($this->at(1))
$platform->expects(self::exactly(2))
->method('getDropForeignKeySQL')
->with($keyConstraintTwo, $tableTwo);
->withConsecutive(
[$keyConstraintOne, $tableOne],
[$keyConstraintTwo, $tableTwo]
);

$collector->acceptForeignKey($tableOne, $keyConstraintOne);
$collector->acceptForeignKey($tableTwo, $keyConstraintTwo);
Expand Down
22 changes: 11 additions & 11 deletions tests/Doctrine/Tests/DBAL/Tools/Console/RunSqlCommandTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@ protected function setUp(): void
$this->commandTester = new CommandTester($this->command);

$this->connectionMock = $this->createMock(Connection::class);
$this->connectionMock->method('fetchAllAssociative')
->willReturn([[1]]);
$this->connectionMock->method('executeUpdate')
->willReturn(42);

$helperSet = ConsoleRunner::createHelperSet($this->connectionMock);
$this->command->setHelperSet($helperSet);
Expand Down Expand Up @@ -97,21 +93,25 @@ public function testUpdateStatementsPrintsAffectedLines(): void
private function expectConnectionExecuteUpdate(): void
{
$this->connectionMock
->expects($this->exactly(1))
->method('executeUpdate');
->expects($this->once())
->method('executeUpdate')
->willReturn(42);

$this->connectionMock
->expects($this->exactly(0))
->expects($this->never())
->method('fetchAllAssociative');
}

private function expectConnectionFetchAllAssociative(): void
{
$this->connectionMock
->expects($this->exactly(0))
->method('executeUpdate');
->expects($this->once())
->method('fetchAllAssociative')
->willReturn([[1]]);

$this->connectionMock
->expects($this->exactly(1))
->method('fetchAllAssociative');
->expects($this->never())
->method('executeUpdate');
}

public function testStatementsWithFetchResultPrintsResult(): void
Expand Down