Simplify test suite configuration #4067
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mysqli
can connect even w/o any parameters). Having to specify them all in a local development environment is unnecessarily tedious.driver
is configured asdb_type
,dbname
is configured asdb_name
. It would be nice to have a direct correspondence.BTW,
tmp_host
,tmp_port
, etc. also look redundant.Change summary
(tmp)db_type
→(tmp)db_driver
(tmp)db_username
→(tmp)db_user
. This isn't nice but it corresponds to the connection parameter name.(tmp)db_name
→(tmp)db_dbname
. This isn't nice either, but this is because we're not configuring a database (db_
), we're configuring a test database connection. We may get rid of thedb_
prefix in parameter names or replace it with something else (e.g.test_
).driver
,host
,port
,user
,password
.