Skip to content

Test SQL Server 17 on Travis #3050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2018
Merged

Conversation

Majkl578
Copy link
Contributor

@Majkl578 Majkl578 commented Mar 15, 2018

Finally managed to solve the problems with running SQL Server 17 on Travis.

The tests are green for the pdo_sqlsrv driver.
Tnere are two failures for the sqlsrv driver:

1) Doctrine\Tests\DBAL\Functional\PortabilityTest::testFetchAllNullColumn
Failed asserting that Array &0 () is identical to Array &0 (
    0 => null
    1 => null
).
/home/travis/build/Majkl578/doctrine-dbal/tests/Doctrine/Tests/DBAL/Functional/PortabilityTest.php:194
2) Doctrine\Tests\DBAL\Functional\WriteTest::testEmptyIdentityInsert
Failed asserting that '17' is greater than '17'.
/home/travis/build/Majkl578/doctrine-dbal/tests/Doctrine/Tests/DBAL/Functional/WriteTest.php:289

@morozov Do you think you can help with these?

I'm not quite sure if this is legally ok to run it on CI & auto-accept EULA though, any opinions?

Not up to date with master due to #3049.

@morozov
Copy link
Member

morozov commented Mar 15, 2018

@Majkl578 Microsoft accepts their own EULA same way on Travis, so I think it should be OK. Maybe we could read the agreement and check what we're agreeing to :)

I'm seeing exactly the same failures on Windows and Linux (#2617 (comment)) so hopefully I can fix them soon.

morozov
morozov previously approved these changes Mar 15, 2018
@morozov
Copy link
Member

morozov commented Mar 15, 2018

@Majkl578 you can try cherry-picking fixes for the failing tests from #2617 so that we could get this merged before AppVeyor is finished.

@Majkl578
Copy link
Contributor Author

@morozov Cherry-picked 87bda6b + bb7e379 + 795b043, build is green now. 💯

@Majkl578
Copy link
Contributor Author

@Majkl578 Majkl578 requested a review from Ocramius March 15, 2018 16:10
@Majkl578
Copy link
Contributor Author

Btw sqlsrv extension fails to compile with nightly, but we can ignore it imho.

@morozov
Copy link
Member

morozov commented Mar 15, 2018

Btw sqlsrv extension fails to compile with nightly, but we can ignore it imho.

I’d say we can disable testing all PECL-based drivers with nightly PHP since it’s a normal thing.

@Majkl578
Copy link
Contributor Author

Ok, nightly stages removed.

@Ocramius Ocramius self-assigned this Mar 16, 2018
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@Ocramius Ocramius added this to the 2.7.0 milestone Mar 16, 2018
@Ocramius Ocramius merged commit 24adecc into doctrine:master Mar 16, 2018
@Majkl578 Majkl578 deleted the travis-mssql branch March 16, 2018 15:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants