removed an else condition, fixed a parameter annotation and make little improvements #3008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlessandroMinoccheri please don't merge |
|
Ok, sorry for the merge... do you prefer to close this and open another wth the rebase @Ocramius ? |
|
You can just rebase your branch and force-push it 👍 |
AlessandroMinoccheri
force-pushed
the
improve_code_inside_query_directory
branch
from
edb4c7e to
6987bda
Compare
|
Sure, no problem to do It |
|
rebase done but travis fails... @Ocramius |
|
@AlessandroMinoccheri failure is clear tho (and related to this change): https://travis-ci.org/doctrine/dbal/jobs/336473229#L576-L582 |
AlessandroMinoccheri
force-pushed
the
improve_code_inside_query_directory
branch
2 times, most recently
from
3548d42 to
603be11
Compare
AlessandroMinoccheri
force-pushed
the
improve_code_inside_query_directory
branch
from
603be11 to
018e0d2
Compare
|
Fixed travis tests |
|
@AlessandroMinoccheri thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.