Extract some constants into TransactionIsolationLevel, TrimMode and DateIntervalUnit #2998
Conversation
Majkl578
force-pushed
the
extract-constants
branch
from
67e6b07 to
c792878
Compare
|
|
||
| namespace Doctrine\DBAL; | ||
|
|
||
| final class TransactionMode |
There was a problem hiding this comment.
Since this class defines transaction isolation levels, would it make sense to name it accordingly?
There was a problem hiding this comment.
Makes sense. So TransactionIsolation or TransactionIsolationLevel?
(edit: Changed to TransactionIsolation, the other one is a bit too long.)
There was a problem hiding this comment.
FWIW, I'd personally prefer TransactionIsolationLevel.
There was a problem hiding this comment.
Alright, changed to TransactionIsolationLevel. A bit long, but makes more sence since there's AbstractPlatform::getDefaultTransactionIsolationLevel(). 👍
| * @param integer $pos The position of the trim (leading/trailing/both). | ||
| * @param string|boolean $char The char to trim, has to be quoted already. Defaults to space. | ||
| * @param string $str The expression to apply the trim to. | ||
| * @param int $pos The position of the trim (leading/trailing/both). |
There was a problem hiding this comment.
Should $pos be renamed to $mode?
There was a problem hiding this comment.
Probably, will change that - didn't check variable names to be honest.
Majkl578
force-pushed
the
extract-constants
branch
from
c792878 to
3e2191a
Compare
Majkl578
changed the title
Majkl578
force-pushed
the
extract-constants
branch
from
3e2191a to
6ee8709
Compare
Majkl578
changed the title
Majkl578
force-pushed
the
extract-constants
branch
from
6ee8709 to
f2a8f75
Compare
Majkl578
force-pushed
the
extract-constants
branch
from
f2a8f75 to
085c970
Compare
|
Manually merged via d9aaf54 |
Similar what we did in #2958 with FetchMode and ParameterType, here comes the same for:
Connection::TRANSACTION_*->TransactionModeTransactionIsolationLevelAbstractPlatform::TRIM_*->TrimModeAbstractPlatform::DATE_INTERVAL_*->DateIntervalUnitThis only moves the constants and deprecates the old ones, not actually removing them yet, should be okay for next 2.x.