[ORACLE] Number Datatype has wrong mapping

[homersimpsons]

Bug Report

Q	A
BC Break	yes ?
Version	(current master)

Summary

NUMBER Datatype is misclassified as 'always integer' as per

dbal/src/Platforms/OraclePlatform.php

Line 1140 in db6f73c

'number' => 'integer',

Looking through the oracle's doc, NUMBER fields, feels more like MySQL's DECIMAL / NUMERIC fields as they both store precise (scaled integer) values.

Current behaviour

NUMBER fields are sometimes wrongly cast to integers.

How to reproduce

Expected behaviour

NUMBER should be mapped as string to avoid any precision issue.

[morozov]

I believe this is the problem about the Integer type per se:

dbal/lib/Doctrine/DBAL/Types/IntegerType.php

Lines 32 to 35 in 9e37d1b

	public function convertToPHPValue($value, AbstractPlatform $platform)
	{
	return $value === null ? null : (int) $value;
	}

Regardless of the platform and the column type, there is a possibility that an integer value in the database doesn't fit into the PHP_INT_MIN...PHP_INT_MAX range.

If there's a problem specifically about a NUMBER field being interpreted as an integer, please provide the steps to reproduce.

[morozov]

I'm curious if as a temporary solution the following might work for you:

$platform->registerDoctrineTypeMapping('number', 'string');

Since PHP doesn't support unsigned or decimal numbers, the only reliable way to represent numbers in PHP is a string.