-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Better support for .dockerignore #721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test setup is failing for Python 3.2 on this line, which is odd.
|
@aanand The Python 3.2 syntax error has been fixed and pathspec 0.3.4 has been released. |
9cbae50
to
eeea7fa
Compare
OK, after some investigation it turns out that pathspec isn't right for us. I've written a fairly comprehensive test suite that covers the correct behaviour (which I confirmed was correct by testing it against actual Here's what's new:
This is ready for review. |
@cpburnz thanks for responding, by the way, and sorry we didn't end up using your library in the end! |
- Support all basic pattern forms: file, directory, *, ?, ! - Fix handling of wildcard patterns and subdirectories - `*/a.py` should match `foo/a.py`, but not `foo/bar/a.py` - Fix handling of directory patterns with a trailing slash - make sure they're handled equivalently to those without one - Fix handling of custom Dockerfiles - make sure they go in the tarball Signed-off-by: Aanand Prasad <[email protected]>
Fixed the build. |
LGTM - thanks! |
Better support for .dockerignore
Builds on @mikexstudios' work in #604, with fixes for Python 2.6 and some refactoring.
Still waiting on version 0.3.4 of pathspec, though - any word on that, @cpburnz?