Build scan plugin as separate package #537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
force-pushed
the
scan_plugin_package
branch
8 times, most recently
from
f92b878 to
472089e
Compare
Signed-off-by: Guillaume Lours <[email protected]>
Alternative solution was to update git on centos7 in /rpm/SPEC/docker-ce-cli.spec:
```
if [ "$SUITE" == "7" ]; then
yum install -y http://opensource.wandisco.com/centos/7/git/x86_64/wandisco-git-release-7-2.noarch.rpm
yum install -y git
fi
```
But rather not changing what is installed on the CEnTOS bistro for the entire CI pipeline
Signed-off-by: Guillaume Tardif <[email protected]>
Signed-off-by: Guillaume Tardif <[email protected]>
This allows building from a source tar.gz if the needed variables (COMMIT, TAG_NAME, PLATFORM_BINARY) are set. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Need to separate this more, because currently, it will inherit the package version from the cli/engine. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Override the package version manually until we have properly separated the control files (etc.) for each package that we build. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
scan_plugin_package
branch
from
472089e to
3497992
Compare
thaJeztah
changed the title
tiborvass
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to separate this more, because currently, the "deb" variant will use the same pacakge version for all packages produces, and inherit the package version from the cli/engine.fixedreplaces / closes #517
replaces / closes #528
closes #530