Skip to content

cli/command/image: Fix total content size calculation in image tree #6000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025

Conversation

vvoland
Copy link
Collaborator

@vvoland vvoland commented Apr 11, 2025

Before this patch, image total content size would only include container images content size.

image
Fix `docker images --tree` not including non-container images content size in the total image content size.

Signed-off-by: Paweł Gronowski [email protected]

Verified

This commit was signed with the committer’s verified signature.
ljharb Jordan Harband
Before this patch, image total content size would only include
container images content size.

Signed-off-by: Paweł Gronowski <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.12%. Comparing base (e286562) to head (1a950db).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6000      +/-   ##
==========================================
- Coverage   59.12%   59.12%   -0.01%     
==========================================
  Files         356      356              
  Lines       29804    29805       +1     
==========================================
  Hits        17621    17621              
- Misses      11207    11208       +1     
  Partials      976      976              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah!

LGTM, thanks!

@thaJeztah thaJeztah merged commit c718d3f into docker:master Apr 11, 2025
100 of 105 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants