cli/command: minor test-fixes and cleanups #5985
Merged
+18
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test verifies the default behavior, but when running the test in an environment that already has a ~/.docker/config.json present, it may fail. This patch updates the test to configure the config-directory to point to an empty directory, making sure it's not affected by state. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Assert that the write succeeded; also changing `Fprintf` to `Fprint`, because we were not using templating (we should check why no linter complained about this). Signed-off-by: Sebastiaan van Stijn <[email protected]>
gotest.tools' fs package only provides very minimal benefits here; use stdlib functions to make things slightly more transparent. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5985 +/- ##
=======================================
Coverage 59.12% 59.12%
=======================================
Files 355 355
Lines 29740 29740
=======================================
Hits 17583 17583
Misses 11182 11182
Partials 975 975 🚀 New features to boost your workflow:
|
Benehiko
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cli/command: TestHooksEnabled: fix test when config file is present
This test verifies the default behavior, but when running the test
in an environment that already has a ~/.docker/config.json present,
it may fail.
This patch updates the test to configure the config-directory to
point to an empty directory, making sure it's not affected by
state.
cli/command: TestNewDockerCliAndOperators fix unhandled errors
Assert that the write succeeded; also changing
FprintftoFprint,because we were not using templating (we should check why no linter
complained about this).
cli/command: use stdlib for temp-dirs
gotest.tools' fs package only provides very minimal benefits here;
use stdlib functions to make things slightly more transparent.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)