Skip to content

cli/command: more go1.19 ("predeclared any") #5131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

nicksieger
Copy link
Member

@nicksieger nicksieger commented Jun 7, 2024

- What I did

  • Add missing go:build go1.19 in cli/command/context/list.go that needs it due to using any

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@nicksieger nicksieger force-pushed the context-list-go1.19 branch from 20d37eb to d0057db Compare June 7, 2024 16:56
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.35%. Comparing base (7ae9f27) to head (d0057db).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5131      +/-   ##
==========================================
- Coverage   61.38%   61.35%   -0.04%     
==========================================
  Files         298      295       -3     
  Lines       20722    20717       -5     
==========================================
- Hits        12720    12710      -10     
- Misses       7102     7104       +2     
- Partials      900      903       +3     

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh 😔

thanks!!

LGTM

@thaJeztah thaJeztah merged commit 2883637 into docker:master Jun 7, 2024
88 checks passed
@thaJeztah thaJeztah added status/4-merge kind/bugfix PR's that fix bugs labels Jun 7, 2024
@thaJeztah thaJeztah added this to the 27.0.0 milestone Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants