Output correct image ID when using Docker with the containerd-snapshotter #3136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctalledo
force-pushed
the
reworked-fix-for-moby-45458
branch
3 times, most recently
from
78578ba to
54d9157
Compare
crazy-max
reviewed
Apr 22, 2025
tonistiigi
reviewed
Apr 22, 2025
commands/build.go
Outdated
| dgst := resp[exptypes.ExporterImageDigestKey] | ||
| if v, ok := resp[exptypes.ExporterImageConfigDigestKey]; ok { | ||
| dgst = v | ||
| func getImageID(resp map[string]string, dockerUsingContainerdSnapshotter bool) string { |
There was a problem hiding this comment.
dockerUsingContainerdSnapshotter should be preferImageDigest.
ctalledo
force-pushed
the
reworked-fix-for-moby-45458
branch
from
54d9157 to
460e2a1
Compare
|
Thanks @tonistiigi for the review and comments, I've answered them, PTAL when you get a chance. Thanks again! |
ctalledo
force-pushed
the
reworked-fix-for-moby-45458
branch
5 times, most recently
from
ddef55c to
abbd9e7
Compare
tonistiigi
reviewed
May 1, 2025
ctalledo
force-pushed
the
reworked-fix-for-moby-45458
branch
from
abbd9e7 to
7343660
Compare
ctalledo
force-pushed
the
reworked-fix-for-moby-45458
branch
2 times, most recently
from
785c473 to
ba3a7fb
Compare
…tter. Prior to this change, the following command emits the wrong image ID when buildx uses the "docker-container" driver and Docker is configured with the containerd-snapshotter. $ docker buildx build --load --iidfile=img.txt $ docker run --rm "$(cat img.txt)" echo hello docker: Error response from daemon: No such image: sha256:4ac37e81e00f242010e42f3251094e47de6100e01d25e9bd0feac6b8906976df. See 'docker run --help'. The problem is that buildx is outputing the incorrect image ID in this scenario (it's outputing the container image config digest, instead of the container image digest used by the containerd-snapshotter). This commit fixes this. See moby/moby#45458. Signed-off-by: Cesar Talledo <[email protected]>
ctalledo
force-pushed
the
reworked-fix-for-moby-45458
branch
from
ba3a7fb to
6794078
Compare
tonistiigi
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the following command emits the wrong image ID when buildx uses the "docker-container" driver and Docker is configured with the containerd-snapshotter.
The problem is that buildx is outputing the incorrect image ID in this scenario (it's outputing the container image config digest, instead of the container image digest used by the containerd-snapshotter).
This commit fixes this. See moby/moby#45458.