avoid import to testing helpers outside of tests #3092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is much more complicated than I would have hoped as some of these helpers are used in integration tests. Tried to separate these into |
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
testing-import-cleanup
branch
from
dadeb4b to
29614f9
Compare
|
Sometimes I wish Go would allow importing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These utilities should not be included in the main build.
This only has a minimal 2.5KB binary size difference atm as there is still import to "testing" via containerd libs atm containerd/containerd#11666 . Removing that one releases more.