driver: request gpu when creating container builder #3063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
reviewed
Mar 13, 2025
driver/docker-container/driver.go
Outdated
| } | ||
| useInit := true | ||
| hc := &container.HostConfig{ | ||
| Privileged: true, |
There was a problem hiding this comment.
I guess Privileged not really required for this test.
crazy-max
force-pushed
the
driver-ctn-gpu-request
branch
from
0cebbba to
c17ea70
Compare
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
driver-ctn-gpu-request
branch
from
c17ea70 to
3375782
Compare
tonistiigi
approved these changes
Mar 13, 2025
crazy-max
commented
Mar 13, 2025
| // hasGPUCapability checks if docker daemon has GPU capability. We need to run | ||
| // a dummy container with GPU device to check if the daemon has this capability | ||
| // because there is no API to check it yet. | ||
| func (d *Driver) hasGPUCapability(ctx context.Context, image string, gpus []container.DeviceRequest) bool { |
There was a problem hiding this comment.
Time this func takes:
- ~15ms on MacOS (no GPU)
- ~230ms on WSL (with GPU)
- ~200ms on WSL (no GPU)
- ~200ms on Windows (with GPU)
- ~160ms on Windows (no GPU)
|
Added follow-up label to have an API for this capability on Moby side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With CDI support added in BuildKit moby/buildkit#4056, we need to request GPUs when creating a container builder.
This is necessary on WSL for Nvidia GPUs because there is no linux drivers available that we could install in BuildKit container during
OnDemandsetup. Mounting/usr/lib/wslworks https://github.com/docker/buildx/compare/master...crazy-max:buildx:driver-ctn-mount-wsl-lib?expand=1 but this is not desired and could be error prone if a remote context/builder is used. So instead we can make a device request when creating the container builder.Can be tested by creating a BuildKit container with ubuntu base:
You can use
crazymax/buildkit:ubuntufor testing on WSL with Nvidia GPU: