bake: allow annotations to be set on the command line #2997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
reviewed
Feb 14, 2025
| @@ -558,7 +558,7 @@ func (c Config) newOverrides(v []string) (map[string]map[string]Override, error) | |||
| // IMPORTANT: if you add more fields here, do not forget to update | |||
| // docs/bake-reference.md and https://docs.docker.com/build/bake/overrides/ | |||
| switch keys[1] { | |||
| case "output", "cache-to", "cache-from", "tags", "platform", "secrets", "ssh", "attest", "entitlements", "network": | |||
| case "output", "cache-to", "cache-from", "tags", "platform", "secrets", "ssh", "attest", "entitlements", "network", "annotations": | |||
There was a problem hiding this comment.
Should we do the same for labels?
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
Just to clarify, this switch is a list of "use ArrValue to fill in the overrides" and the default is to use Value if you're not in the list.
crazy-max
reviewed
Feb 14, 2025
Annotations were not merged correctly. The overrides in `ArrValue` would be merged, but the section of code setting them from the command line did not include `annotations` in the list of available attributes so the command line option was completely discarded. Signed-off-by: Jonathan A. Sternberg <[email protected]>
jsternberg
force-pushed
the
bake-set-annotations
branch
from
29f30b8 to
d6fdf83
Compare
crazy-max
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotations were not merged correctly. The overrides in
ArrValuewould be merged, but the section of code setting them from the command line did not includeannotationsin the list of available attributes so the command line option was completely discarded.Fixes #2989.