How can I append tags with --set ?

[back-2-95]

I have target like:

target "fpm-73" {
  ...
  tags = ["repo/php:7.3-fpm", "repo/php:7.3-fpm-latest"]
}

I'm getting Minor version outside of docker-bake.hcl, e.g. 7.3.27 so I'd like to append a tag to the target tags:

docker buildx bake --print --pull --push --set fpm-73.tags=repo/php:7.3.27

Now with that ^^ the tags list from hcl file gets overriden totally.

[back-2-95]

Got around this with:

PHP_MINOR_VERSION=7.3.27 docker buildx bake --print --pull --push

And in docker-bake.hcl:

variable PHP_MINOR_VERSION {}

target "fpm-73" {
  ...
  tags = ["repo/php:7.3-fpm", "repo/php:${PHP_MINOR_VERSION}-fpm-latest", "repo/php:7.3-fpm-latest"]
}

[tonistiigi]

I don't think this is currently possible. We've discussed things like --set fpm-73.tags+=repo/php:7.3.27

[errordeveloper]

We've discussed things like --set fpm-73.tags+=repo/php:7.3.27

Personally I find mini-languages in flags a bit over the top, --set flag is already complex enough. Using HCL variables seems like a viable solution.

[back-2-95]

Yeah, I have been quite happy with HCL variable thing there ^^
It also reminds passing args to Dockerfile.

[thompson-shaun]

Related to #901?

[crazy-max]

I took a look at this one and it seems for entitlements, annotations and attest attributes we already append:

buildx/bake/bake.go

Lines 963 to 979 in 921b576

	case "entitlements":
	t.Entitlements = append(t.Entitlements, o.ArrValue...)
	for _, v := range o.ArrValue {
	if v == string(EntitlementKeyNetworkHost) {
	ent.NetworkHost = true
	} else if v == string(EntitlementKeySecurityInsecure) {
	ent.SecurityInsecure = true
	}
	}
	case "annotations":
	t.Annotations = append(t.Annotations, o.ArrValue...)
	case "attest":
	attest, err := parseArrValue[buildflags.Attest](o.ArrValue)
	if err != nil {
	return errors.Wrap(err, "invalid value for attest")
	}
	t.Attest = t.Attest.Merge(attest)

. In such case += is already the default for these attributes. Making them an actual override would be a breaking change 🤔

Like:

		case "annotations":
			if o.Append {
				t.Annotations = append(t.Annotations, o.ArrValue...)
			} else {
				t.Annotations = o.ArrValue
			}