Skip to content

Update for updated OpenJDK base images #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2019

Conversation

tianon
Copy link
Member

@tianon tianon commented May 28, 2019

This is initial adjustments for docker-library/openjdk#322.

FYI to FROM tomcat official-images maintainers:

@tianon tianon force-pushed the openjdk-downstream branch from ba24eee to 7eae995 Compare May 28, 2019 22:13
@vmassol
Copy link

vmassol commented May 29, 2019

@tianon thanks for the heads up!

So at XWiki we're using FROM tomcat:8-jre8 which itself was using FROM openjdk:8-jre. From what I see in this PR, this hasn't been changed, right? (when I search for 8-jre8 in the PR I don't get a hit).

Anything we should check specifically?

Thanks again

@tianon
Copy link
Member Author

tianon commented May 29, 2019

@vmassol all "jre" variants of the tomcat image are going away because we have to have the JDK to compile Tomcat Native and don't have an easy way to install that temporarily like we did with the Debian-package-based openjdk:jre images 😞

@tianon
Copy link
Member Author

tianon commented May 29, 2019

(that might be something that could change with docker-library/official-images#5929, but as-is it's not something we can commit to right now 😞)

@tianon tianon merged commit 09406a3 into docker-library:master May 29, 2019
@tianon tianon deleted the openjdk-downstream branch May 29, 2019 19:40
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request May 29, 2019
Changes:

- docker-library/tomcat@09406a3: Merge pull request docker-library/tomcat#158 from infosiftr/openjdk-downstream
- docker-library/tomcat@7eae995: Update for updated OpenJDK base images
@vmassol
Copy link

vmassol commented May 30, 2019

@tianon ok so we need to move from FROM tomcat:8-jre8 to FROM tomcat:8-jdk8. I'll be making the change and send a PR. Thanks

@nicolas-albert
Copy link

I cannot test anything before Monday. How can we test a tomcat based image based on the AdoptOpenJdk ?

vmassol added a commit to vmassol/official-images that referenced this pull request May 30, 2019
@tianon
Copy link
Member Author

tianon commented May 31, 2019

@nicolas-albert there aren't any tomcat images based on AdoptOpenJDK right now (that's being discussed in #134)

I think the confusion is that the binaries we're using for openjdk are hosted by AdoptOpenJDK, but they're not AdoptOpenJDK (they're completely vanilla OpenJDK).

The concrete outcome here for convertigo is going to be similar to either what's happening with xwiki in docker-library/official-images#5990 (moving to the new tomcat:jdk variants and dropping architectures and Alpine variants) or considering https://hub.docker.com/_/adoptopenjdk instead (and thus either waiting for #134 or essentially maintaining your own Tomcat image).

juanluisrp added a commit to juanluisrp/docker-geonetwork that referenced this pull request Aug 26, 2019
Due to docker-library/tomcat#158 jre8 based images
are no longer available. Use jdk8 based images instead.
juanluisrp added a commit to geonetwork/docker-geonetwork that referenced this pull request Aug 28, 2019
Due to docker-library/tomcat#158 jre8 based images
are no longer available. Use jdk8 based images instead.
MattBlissett added a commit to gbif/docker-ipt that referenced this pull request Sep 17, 2019
MattBlissett added a commit to gbif/docker-ipt that referenced this pull request Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants