-
Notifications
You must be signed in to change notification settings - Fork 602
Support building on an arm64 host too #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Doh, this will fail without emulation too: Lines 23 to 29 in 6ad8af5
I wish we had an easier way to invoke https://github.com/docker-library/bashbrew/blob/86212cac9100bf6163bc91a0560e7cbc6b1da995/scripts/bashbrew-host-arch.sh, which I guess would have to happen inside a container too since that's the real "arch" we're testing here (and may even be a remote system) 😭 |
I think this might be good enough for a first step? |
I think I can do something ~simple to resolve it 😅 |
Oh, and we don't need https://github.com/docker-library/bashbrew/blob/86212cac9100bf6163bc91a0560e7cbc6b1da995/scripts/bashbrew-host-arch.sh because we already have the mappings, we just have to use/record them somewhere 😅 😇 |
13a1354
to
f1b57db
Compare
This adds a `.host-arch` symlink to build output; this doesn't get committed (for hopefully obvious reasons), but allows for things like `CMD` and `update.sh` to have a known-effective target for testing the output further in some way. This was a mapping we already had thanks to `ARCH_TEST`, so I've also reordered our builds such that they're grouped by "host" architecture and sorted by "preference"/compatibility (with the goal that we get a more "correct" `.host-arch` symlink).
f1b57db
to
f689a8d
Compare
|
Changes: - docker-library/hello-world@5b5487f: Update shebang from /bin/bash to /usr/bin/env bash - docker-library/hello-world@337f857: Merge pull request docker-library/hello-world#127 from infosiftr/arm64-host - docker-library/hello-world@f689a8d: Support building on an arm64 host too
Changes: - docker-library/hello-world@5b5487f: Update shebang from /bin/bash to /usr/bin/env bash - docker-library/hello-world@337f857: Merge pull request docker-library/hello-world#127 from infosiftr/arm64-host - docker-library/hello-world@f689a8d: Support building on an arm64 host too
Changes: - docker-library/hello-world@8ffde12: Merge pull request docker-library/hello-world#128 from infosiftr/rm-1809 - docker-library/hello-world@d2ad81c: Remove Windows Server 2019 / 1809 - docker-library/hello-world@5b5487f: Update shebang from /bin/bash to /usr/bin/env bash - docker-library/hello-world@337f857: Merge pull request docker-library/hello-world#127 from infosiftr/arm64-host - docker-library/hello-world@f689a8d: Support building on an arm64 host too
cc @LaurentGoderre
(the rest of the image build is appropriately using the full compiler prefixes and
arch-test
to verify executability, even on amd64)