Resolved issue with file watching and browsersync
#6050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchelsellers
approved these changes
May 28, 2024
bdukes
reviewed
May 28, 2024
Rollup handles this with the chokidarWatch and browserSync shown in https://github.com/dnnsoftware/Dnn.Platform/pull/6050/files#diff-898a305ddbc9104ca302578ccf5e847a95eda1ddda928e8ab585904a25d64b0cR18-R39 |
bdukes
approved these changes
May 28, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #6049
There were several issues here, but the fundamental change was to implement
chokidarfor better file watching and triggering ofbrowsersync.